Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jphillips/v8 12.5 #2104

Merged
merged 1 commit into from
May 10, 2024
Merged

Jphillips/v8 12.5 #2104

merged 1 commit into from
May 10, 2024

Conversation

jp4a50
Copy link
Collaborator

@jp4a50 jp4a50 commented May 9, 2024

Non-trivial changes:

  • V8 appears to be in the process of supporting the explicit resource management spec. Since Symbol.dispose has been exposed to JS I've patched v8 to expose it via a native API so we can now use v8's Symbol.dispose for our JS RPC implementation.
  • Node’s util.inspect changed behaviour due to the following V8 change: https://chromium-review.googlesource.com/c/v8/v8/+/5378709. I've patched the tests to reflect the new behaviour.

@jp4a50 jp4a50 requested review from a team as code owners May 9, 2024 16:04
@jp4a50 jp4a50 requested review from mikea and garrettgu10 May 9, 2024 16:04
@jp4a50 jp4a50 requested a review from jasnell May 9, 2024 16:13
@jp4a50 jp4a50 merged commit 34a2739 into main May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants