Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Reduce set of build dependencies #2163

Merged
merged 1 commit into from
May 28, 2024
Merged

[CI] Reduce set of build dependencies #2163

merged 1 commit into from
May 28, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented May 24, 2024

Be more intentional about what dependencies we use. This should make CI run a bit faster.

===========

Was inspired to do this while debugging an internal CI issue. We have long resolved our CI space constraints by not building everything twice and using shared linkage, but this should still speed up the build process slightly.

@fhanau fhanau force-pushed the felix/llvm-dep-cleanup branch 4 times, most recently from 18ec565 to 80ff54c Compare May 25, 2024 02:24
@fhanau fhanau requested a review from mikea May 25, 2024 02:26
@fhanau fhanau marked this pull request as ready for review May 25, 2024 02:27
@fhanau fhanau requested review from a team as code owners May 25, 2024 02:27
@fhanau fhanau requested a review from hoodmane May 25, 2024 02:27
Be more intentional about what dependencies we use. This should make CI
run a bit faster.
@fhanau
Copy link
Collaborator Author

fhanau commented May 28, 2024

Rebased this and updated .github/workflows/npm-types.yml, where we also install clang manually as of #2173.

@fhanau fhanau merged commit 384c51a into main May 28, 2024
10 checks passed
@fhanau fhanau deleted the felix/llvm-dep-cleanup branch May 28, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants