Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nfc] enabling asan leak sanitizer #2187

Merged
merged 2 commits into from
May 29, 2024
Merged

[nfc] enabling asan leak sanitizer #2187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
021f55a
[nfc] enabling asan leak sanitizer
mikea May 29, 2024
92e422e
disabling modules-new-test temporarily
mikea May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ build:sanitizer-common --copt="-fno-omit-frame-pointer" --copt="-mno-omit-leaf-f
build:asan --config=sanitizer-common
build:asan --copt="-fsanitize=address" --linkopt="-fsanitize=address"
build:asan --test_env=ASAN_OPTIONS=abort_on_error=true
build:asan --test_env=KJ_CLEAN_SHUTDOWN=1

#
# Linux and macOS
Expand Down
2 changes: 2 additions & 0 deletions src/workerd/jsg/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ wd_cc_library(
exclude = [
# defined below
"macro-meta-test.c++",
# TODO(jasnell) modules-new-test is leaking IsolateModuleRegistry and fails asan leak detector
"modules-new-test.c++",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For others reviewing, the modules-new-test is currently the only thing using IsolateModuleRegistry while the new implementation is still being developed. Disabling the test is safe and I'll be revisiting this as I continue work on the new module registry implementation.

"resource-test.c++",
"rtti-test.c++",
"url-test.c++",
Expand Down
Loading