[build] Reduce STL header include overhead, O0 code size #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fhanau
commented
Jul 5, 2024
•
fhanau
commented
- The include and code size optimizations are already enabled in the downstream project.
- Use cleaner syntax when disabling legacy_external_runfiles.
fhanau
force-pushed
the
felix/070524-build-improvements
branch
from
9c04869
to
830e531
Compare
fhanau
force-pushed
the
felix/070524-build-improvements
branch
from
830e531
to
05abfa7
Compare
fhanau
changed the title
jasnell
approved these changes
Aug 1, 2024
- The include and code size optimizations are already enabled in the downstream project. - Use cleaner syntax to remove legacy_external_runfiles.
fhanau
force-pushed
the
felix/070524-build-improvements
branch
from
05abfa7
to
454f317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.