-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to V8 12.8 #2441
Update to V8 12.8 #2441
Conversation
2f35cae
to
e4a4890
Compare
The failure with |
- Drop patch setting V8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA, the V8 bazel build now enables it by default - Update promise context tagging patch following V8 type casting changes - Update absl and ICU dependencies to version used by V8 - Manually add define for Windows 10 which is now required by V8, this is not reflected in V8's bazel files so far.
We were already using the new behavior here, but V8 now wants us to use the default constructor instead of passing the new option.
The compiler would drop the reference otherwise, resulting in the info parameter being copyied implicitly. This caused //src/workerd/io:promise-wrapper-test to fail.
V8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA
, the V8 bazel build now enables it by defaultreflected in V8's bazel files so far.