Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to V8 12.8 #2441

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Update to V8 12.8 #2441

merged 5 commits into from
Aug 14, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Jul 25, 2024

  • Drop patch setting V8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA, the V8 bazel build now enables it by default
  • Update promise context tagging patch following V8 type casting changes
  • Update absl and ICU dependencies to version used by V8
  • Manually add define for Windows 10 which is now required by V8, this is not
    reflected in V8's bazel files so far.
  • Upgrade LLVM 15 => 16 to support V8 12.8
  • Resolve EmbedderRootsHandler deprecation warning
  • Backport wasm race condition fixes – this resolves test failures under ASan.

@jasnell
Copy link
Member

jasnell commented Aug 12, 2024

The failure with promise-wrapper-test appears to be caused by the use of SetNativeDataProperty(...) when configuring the read-only property. Switching to using SetAccessorProperty(...) allows the test to pass but has other side effects. We had to make a similar change with regards to non-read only properties recently so it appears the v8 continued to make some changes here that change the behavior of SetNativeDataProperty(...) further.

- Drop patch setting V8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA, the V8
  bazel build now enables it by default
- Update promise context tagging patch following V8 type casting changes
- Update absl and ICU dependencies to version used by V8
- Manually add define for Windows 10 which is now required by V8, this is not
  reflected in V8's bazel files so far.
We were already using the new behavior here, but V8 now wants us to use the
default constructor instead of passing the new option.
@fhanau fhanau requested a review from jasnell August 13, 2024 13:07
@fhanau fhanau marked this pull request as ready for review August 13, 2024 13:07
@fhanau fhanau requested review from a team as code owners August 13, 2024 13:07
The compiler would drop the reference otherwise, resulting in the info parameter
being copyied implicitly. This caused //src/workerd/io:promise-wrapper-test to
fail.
@fhanau fhanau merged commit 3f57135 into main Aug 14, 2024
9 checks passed
@fhanau fhanau deleted the felix/v8-128 branch August 14, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants