Generate package memory snapshot for validator. #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
force-pushed
the
dominik/gen-package-snapshot-in-validator
branch
3 times, most recently
from
36ea3bb
to
b7c825d
Compare
dom96
requested review from
ObsidianMinor,
AdityaAtulTewari,
hoodmane and
garrettgu10
hoodmane
approved these changes
Jul 26, 2024
|
Changes like this are going to become annoying after we start making compat dates correspond to a fixed pyodide capnp bundle... |
hoodmane
reviewed
Jul 26, 2024
dom96
force-pushed
the
dominik/gen-package-snapshot-in-validator
branch
3 times, most recently
from
9f8fba6
to
cbe9294
Compare
dom96
force-pushed
the
dominik/gen-package-snapshot-in-validator
branch
from
cbe9294
to
cba9d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies memory snapshot generation to generate a package snapshot- one that only includes imports of modules that are not present in the user's worker bundle.
Reuses the existing AST walker to collect the import names and pushes them out to the validator.
Tested upstream.