VS-257: Fix Vectorize query options #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penalosa
reviewed
Aug 5, 2024
garvit-gupta
force-pushed
the
garvit/VS-257/fix-vectorize-types
branch
from
28f21c5
to
0bfd15b
Compare
RamIdeas
reviewed
Aug 14, 2024
RamIdeas
approved these changes
Aug 14, 2024
garvit-gupta
force-pushed
the
garvit/VS-257/fix-vectorize-types
branch
2 times, most recently
from
538774b
to
0bfd15b
Compare
jasnell
reviewed
Aug 15, 2024
| @@ -114,7 +114,7 @@ export default { | |||
| returnSet.forEach((v) => { | |||
| delete v.values; | |||
| }); | |||
| if (!body?.returnMetadata) | |||
| if (!body?.returnMetadata || body?.returnMetadata === "none") | |||
There was a problem hiding this comment.
Suggested change
| if (!body?.returnMetadata || body?.returnMetadata === "none") | |
| if ((body?.returnMetadata || 'none') === "none") |
nit: Might be a bit cleaner
jasnell
approved these changes
Aug 15, 2024
anonrig
approved these changes
Aug 15, 2024
|
@jasnell is internal pr needed for this change? |
|
To be safe I think we should have an internal CI run yes. |
garvit-gupta
force-pushed
the
garvit/VS-257/fix-vectorize-types
branch
from
0bfd15b
to
13044c0
Compare
|
Internal CI run was goodl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes 2 aspects of Vectorize query options.
Options itself should be an optional field.
Options.returnMetadata should be of type boolean for Vectorize V1 and of type
VectorizeMetadataRetrievalLevelfor Vectorize V2. The existing type relied on a generic to assign type appropriately for the operation, but did not work as expected for Vectorize V2. It continued to expect a boolean field for V2 as well instead ofVectorizeMetadataRetrievalLevel.Follows: #2443