Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add initial zlib module with crc32 #2477

Merged
merged 1 commit into from
Aug 5, 2024
Merged

add initial zlib module with crc32 #2477

merged 1 commit into from
Aug 5, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 5, 2024

Initializes node:zlib and implements only crc32 for now.

@anonrig anonrig requested a review from jasnell August 5, 2024 15:54
@anonrig anonrig requested review from a team as code owners August 5, 2024 15:54
@anonrig anonrig requested a review from jp4a50 August 5, 2024 15:54
garrettgu10
garrettgu10 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@garrettgu10 garrettgu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/workerd/api/node/tests/zlib-nodejs-test.js


// The following test data comes from
// https://github.com/zlib-ng/zlib-ng/blob/5401b24/test/test_crc32.cc
Copy link
Collaborator

@garrettgu10 garrettgu10 Aug 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the comment on testcase sourcing, hope to see more of this in the future

@anonrig anonrig merged commit 920ff29 into main Aug 5, 2024
8 of 9 checks passed
@anonrig anonrig deleted the yagiz/zlib-crc32 branch August 5, 2024 19:41
@npaun npaun mentioned this pull request Aug 6, 2024
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettgu10 garrettgu10 garrettgu10 approved these changes

@jasnell jasnell jasnell approved these changes

@jp4a50 jp4a50 Awaiting requested review from jp4a50 jp4a50 is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
api frameworks nodejs compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anonrig @jasnell @garrettgu10