Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add file class to node:buffer #2484

Merged
merged 1 commit into from
Aug 9, 2024
Merged

add file class to node:buffer #2484

merged 1 commit into from
Aug 9, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 6, 2024 •
edited
Loading

  • Adds File to node:buffer
  • Fixes Blob and File typescript definitions
  • Fixes passing NaN as a lastModified to File options.

@anonrig anonrig requested review from a team as code owners August 6, 2024 16:10
@anonrig anonrig force-pushed the yagiz/add-file-class branch 4 times, most recently from 60387b5 to 691c787 Compare August 6, 2024 18:09
@anonrig anonrig requested a review from npaun August 6, 2024 18:11
npaun
npaun approved these changes Aug 6, 2024
View reviewed changes
src/node/internal/web_crypto.d.ts Show resolved Hide resolved
jasnell
jasnell reviewed Aug 7, 2024
View reviewed changes
pnpm-lock.yaml Show resolved Hide resolved
jasnell
jasnell approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's have the @workers-frameworks folks take a look.

dario-piotrowicz
dario-piotrowicz approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

src/workerd/api/node/tests/buffer-nodejs-test.js Outdated Show resolved Hide resolved
vicb
vicb reviewed Aug 7, 2024
View reviewed changes
Copy link

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments on this file.

This PR also touches crypto, what is the reason, could it be a distinct commit?

As I was explaining to Dario earlier, I usually add a lot of comments when I review code. Feel free to ignore them if not applicable.

src/node/buffer.ts Outdated Show resolved Hide resolved
src/node/internal/crypto_random.ts Outdated Show resolved Hide resolved
src/node/internal/crypto_random.ts Outdated Show resolved Hide resolved
src/workerd/api/blob.c++ Outdated Show resolved Hide resolved
src/workerd/api/node/tests/buffer-nodejs-test.js Show resolved Hide resolved
src/workerd/api/node/tests/buffer-nodejs-test.js Outdated Show resolved Hide resolved
@anonrig
Copy link
Member Author

anonrig commented Aug 8, 2024

Internal PR needs to land first, since we need to update @types/node in there as well.

@anonrig anonrig merged commit fe883d8 into main Aug 9, 2024
9 of 10 checks passed
@dario-piotrowicz dario-piotrowicz deleted the yagiz/add-file-class branch August 9, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@npaun npaun npaun approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@vickykont vickykont Awaiting requested review from vickykont vickykont is a code owner automatically assigned from cloudflare/workers-runtime-1

@vicb vicb Awaiting requested review from vicb

Assignees
No one assigned
Labels
api frameworks nodejs compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @vicb @jasnell @npaun @dario-piotrowicz