Add nbytes as a dependency and reuse code from Node.js #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/add-nbytes
branch
from
aee5121
to
93e8756
Compare
jasnell
reviewed
Aug 7, 2024
jasnell
approved these changes
Aug 7, 2024
|
lgtm once CI passes and the internal PR is open adding the dependency there |
anonrig
force-pushed
the
yagiz/add-nbytes
branch
2 times, most recently
from
71f6eb7
to
baceba3
Compare
jasnell
reviewed
Aug 9, 2024
anonrig
force-pushed
the
yagiz/add-nbytes
branch
3 times, most recently
from
fcff0c6
to
1b33f77
Compare
fhanau
approved these changes
Aug 12, 2024
anonrig
force-pushed
the
yagiz/add-nbytes
branch
from
1b33f77
to
2149f38
Compare
mikea
approved these changes
Aug 12, 2024
anonrig
force-pushed
the
yagiz/add-nbytes
branch
from
2149f38
to
fb6b039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several weeks ago, @jasnell and I moved
nbytesinto a different repository to reuse Node.js' implementation. Here's the follow up of that work.Nbytes: https://github.com/nodejs/nbytes