Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Workflow entrypoint and types #2492

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add Workflow entrypoint and types #2492

merged 1 commit into from
Aug 14, 2024

Conversation

sidharthachatterjee
Copy link
Collaborator

@sidharthachatterjee sidharthachatterjee commented Aug 7, 2024 •
edited
Loading

  • Adds a new entrypoint class for Workflows with a constructor that sets up ctx and env
  • Adds types for Workflows in cloudflare:workers
  • Ensures Workflow entrypoint class is only registered if workerd is running with the experimental compatibility flag

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sidharthachatterjee
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 7, 2024
@github-actions
@sidharthachatterjee has signed the CLA in #2492
5aefaba
kentonv
kentonv reviewed Aug 8, 2024
View reviewed changes
src/workerd/server/workerd-api.c++ Show resolved Hide resolved
src/workerd/io/worker.c++ Outdated Show resolved Hide resolved
@sidharthachatterjee sidharthachatterjee changed the title wip: Add workflow entrypoint Add Workflow entrypoint and types Aug 13, 2024
@sidharthachatterjee
Add Workflow entrypoint and types
75ca532 
Includes abstract class Workflow in cloudflare:workers, ensures Workflow entrypoint class is only registered if workerd is running with the experimental compatibility flag
jasnell
jasnell approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but ideally this would come with at least one test. Is there a plan to add testing soon?

@sidharthachatterjee
Copy link
Collaborator Author

LGTM but ideally this would come with at least one test. Is there a plan to add testing soon?

Yeah, we've been iterating quickly on API shape. I'm going to open another PR with some comprehensive testing shortly.

@jasnell
Copy link
Member

jasnell commented Aug 14, 2024

Internal CI run appears to be successful and green so removing the needs-internal-pr label.

@sidharthachatterjee sidharthachatterjee merged commit 97955fd into main Aug 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@elithrar elithrar elithrar left review comments

@kentonv kentonv kentonv approved these changes

@jasnell jasnell jasnell approved these changes

@a-robinson a-robinson Awaiting requested review from a-robinson a-robinson is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sidharthachatterjee @jasnell @elithrar @anonrig @kentonv