[nfc] 08/10/24 Build/Docs cleanup #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
commented
Aug 10, 2024
| @@ -56,6 +56,7 @@ namespace workerd::server { | |||
|
|
|||
| using api::pyodide::PythonConfig; | |||
|
|
|||
| namespace { | |||
There was a problem hiding this comment.
Adding this closure is high-impact because JsgWorkerdIsolate instantiates the entire workerd JS API – on macOS compiling without optimization sees little impact to compile time or object code size (41.1MB => 40.6MB), but under -O3 there is a large impact on both (38.2s => 51.8s, 15.1MB => 10.3MB). Compiling workerd-api.c++ is a bottleneck for the build, but I think this is worth it since such tradeoffs are what we are looking for when optimization is enabled, we might also see faster LTO link times as there is less code to be optimized at that stage.
fhanau
force-pushed
the
felix/081024-build-cleanup
branch
from
3789627
to
5d6c003
Compare
anonrig
approved these changes
Aug 12, 2024
- Emphasize that building on macOS requires Xcode. - Clean up Windows dependency script, the workaround is no longer needed. - Fix cargo-culted comment in encoding-test.js - Drop unused perfetto dependency for node target - Mark a few classes as final, expand anonymous namespace usage.
fhanau
force-pushed
the
felix/081024-build-cleanup
branch
from
5d6c003
to
d4393fc
Compare
jasnell
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning out a number of smaller changes I had stashed for a while.