Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Workflow TS types #2550

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix Workflow TS types #2550

merged 1 commit into from
Aug 19, 2024

Conversation

sidharthachatterjee
Copy link
Collaborator

run always returns a Promise and so do individual steps

@sidharthachatterjee
Fix Workflow TS types
b19e99e 
run always returns a Promise and so do individual steps
LuisDuarte1
LuisDuarte1 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@LuisDuarte1 LuisDuarte1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sidharthachatterjee sidharthachatterjee merged commit b601ea6 into main Aug 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penalosa penalosa penalosa approved these changes

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@danlapid danlapid danlapid approved these changes

@ObsidianMinor ObsidianMinor Awaiting requested review from ObsidianMinor ObsidianMinor is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sidharthachatterjee @danlapid @LuisDuarte1 @penalosa