Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix node eslintrc.json project path #2554

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix node eslintrc.json project path #2554

merged 2 commits into from
Aug 19, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 19, 2024 •
edited
Loading

This was locally causing issues for me. Using a relative path in project causes clion errors to go away.

@anonrig anonrig requested a review from npaun August 19, 2024 19:58
@anonrig anonrig requested review from a team as code owners August 19, 2024 19:58
@anonrig anonrig requested review from harrishancock and jasnell and removed request for harrishancock August 19, 2024 19:58
@anonrig anonrig mentioned this pull request Aug 19, 2024
Merged
2 tasks
npaun
npaun approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@npaun npaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've been having the same issue on my machine.

@anonrig anonrig merged commit 2561f1f into main Aug 19, 2024
9 checks passed
@anonrig anonrig deleted the yagiz/fix-node-eslintrc branch August 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npaun npaun npaun approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @npaun