-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoformatting for Bazel files #2577
Conversation
0117eed
to
b3f78e3
Compare
ddd9522
to
e9909ed
Compare
I think @fhanau approval on this is a condition for merging |
See internal PR 8342 for some prior work on enabling buildifier automatically on the downstream repo – I was planning to patch up that PR today but looks like you got here first. It uses a different approach to downloading buildifier that I think is preferable, but I'll have to incorporate Dan's suggestions on how to invoke it – will provide some detailed notes on that later today and review this. |
Seems to me like we mind as well land this change as is and you can convert the installation method in a separate PR later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependant on @fhanau approval of bazel file changes.
This also applies for the other linters we added be we should document that buildifier needs to be installed as running the formatter is now a key part of development, even if invoked indirectly. |
e9909ed
to
1948619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for this not being documented, but that goes for the other linters too.
391abde
to
86b225a
Compare
I added a new issue to document the linters: #2581 |
No description provided.