Move the default implied on date for nodejs-compat-v2 #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/move-default-on-date-nodejs-compat-v2
branch
from
a2194fc
to
917977f
Compare
vicb
reviewed
Aug 27, 2024
jasnell
commented
Aug 27, 2024
irvinebroque
approved these changes
Aug 27, 2024
jasnell
force-pushed
the
jsnell/move-default-on-date-nodejs-compat-v2
branch
from
de6c0bc
to
ff7872b
Compare
Push back the date where nodejs-compat implies nodejs-compat-v2
jasnell
force-pushed
the
jsnell/move-default-on-date-nodejs-compat-v2
branch
from
ff7872b
to
9e445f1
Compare
dom96
approved these changes
Aug 27, 2024
|
The date is intended to align with the start of birthday week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push back the date where nodejs-compat implies nodejs-compat-v2
@dom96 @vickykont ... this would need to go out into a release this week.