Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packages to ArtifactBundler #2618

Merged
merged 11 commits into from
Sep 13, 2024
Merged

Add packages to ArtifactBundler #2618

merged 11 commits into from
Sep 13, 2024

Conversation

garrettgu10
Copy link
Collaborator

Related to downstream PR 8540

@garrettgu10 garrettgu10 requested review from a team as code owners August 27, 2024 20:34
anonrig
anonrig approved these changes Aug 28, 2024
View reviewed changes
src/workerd/api/pyodide/pyodide.c++ Outdated Show resolved Hide resolved
@garrettgu10 garrettgu10 force-pushed the ggu/packages-in-artifact-bundler branch 2 times, most recently from 39b9bc1 to 7c2c621 Compare August 28, 2024 22:10
@garrettgu10 garrettgu10 mentioned this pull request Aug 30, 2024
Merged
@garrettgu10 garrettgu10 force-pushed the ggu/packages-in-artifact-bundler branch from 16993cf to e0e4782 Compare September 4, 2024 16:36
dom96
dom96 approved these changes Sep 5, 2024
View reviewed changes
src/workerd/api/pyodide/pyodide.h Outdated Show resolved Hide resolved
@garrettgu10 garrettgu10 requested a review from a team as a code owner September 5, 2024 21:03
@garrettgu10 garrettgu10 force-pushed the ggu/packages-in-artifact-bundler branch 2 times, most recently from 4d2b06e to a8c297f Compare September 9, 2024 19:44
hoodmane
hoodmane reviewed Sep 10, 2024
View reviewed changes
src/pyodide/internal/loadPackage.ts Outdated Show resolved Hide resolved
src/pyodide/internal/loadPackage.ts Outdated Show resolved Hide resolved
src/pyodide/internal/loadPackage.ts Outdated Show resolved Hide resolved
src/pyodide/internal/setupPackages.ts Show resolved Hide resolved
src/pyodide/python-entrypoint-helper.ts Outdated Show resolved Hide resolved
src/workerd/api/pyodide/pyodide.c++ Show resolved Hide resolved
src/workerd/api/pyodide/pyodide.h Outdated Show resolved Hide resolved
src/workerd/api/pyodide/pyodide.h Show resolved Hide resolved
@garrettgu10 garrettgu10 changed the title Add PackagePromiseMap to ArtifactBundler Add packages to ArtifactBundler Sep 10, 2024
dom96
dom96 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few questions/nits.

src/pyodide/internal/loadPackage.ts Outdated Show resolved Hide resolved
src/pyodide/internal/loadPackage.ts Outdated Show resolved Hide resolved
src/workerd/api/pyodide/pyodide.h Show resolved Hide resolved
@garrettgu10 garrettgu10 force-pushed the ggu/packages-in-artifact-bundler branch 2 times, most recently from 6ebaea9 to 57b76b5 Compare September 11, 2024 15:47
@mar-cf mar-cf removed their request for review September 12, 2024 16:18
@garrettgu10 garrettgu10 force-pushed the ggu/packages-in-artifact-bundler branch from 6538777 to 5bf0f99 Compare September 13, 2024 02:22
@garrettgu10 garrettgu10 merged commit 157fe35 into main Sep 13, 2024
13 checks passed
@garrettgu10 garrettgu10 deleted the ggu/packages-in-artifact-bundler branch September 13, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoodmane hoodmane hoodmane left review comments

@dom96 dom96 dom96 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garrettgu10 @dom96 @anonrig @hoodmane