[build] Further zlib build refactor, document new hardware requirements #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
commented
Aug 29, 2024
jasnell
approved these changes
Aug 29, 2024
npaun
approved these changes
Aug 29, 2024
Also fixes a potential build failure for arm64 – the zlib_arm_crc32 target did not have the required crc32 extension enabled. This did not surface on Apple Silicon builds as the extension is supported by all Apple Silicon CPUs and enabled unconditionally.
fhanau
force-pushed
the
felix/gn-zlib-cleanup-v2
branch
from
cd687e0
to
da503ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a potential build failure for arm64 – the
zlib_arm_crc32target did not have the required crc32 extension enabled. This did not surface on Apple Silicon builds as the extension is supported by all Apple Silicon CPUs and enabled unconditionally.