Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more node:zlib tests #2628

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Add some more node:zlib tests #2628

merged 1 commit into from
Aug 29, 2024

Conversation

npaun
Copy link
Member

@npaun npaun commented Aug 29, 2024

This PR translates the following tests from NodeJS:

  • test-zlib-truncated.js
  • test-zlib-from-concatenated-gzip.js
  • test-zlib-not-string-or-buffer.js
  • test-zlib-from-gzip-with-trailing-garbage.js
  • test-zlib-from-string.js
  • test-zlib-empty-buffer.js

I've removed any existing tests that were redundant with Node's tests. In the process of implementing these tests, I've found two bugs:

  • unzip was using the wrong ZlibMode [fixed]
  • an issue when streaming multi-member archives [test commented out until this is solved]

I think we don't need any equivalent to this test:

@npaun npaun requested review from jasnell and anonrig August 29, 2024 18:11
@npaun npaun requested review from a team as code owners August 29, 2024 18:11
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
src/workerd/api/node/tests/zlib-nodejs-test.js Outdated Show resolved Hide resolved
@npaun npaun merged commit bd512d0 into main Aug 29, 2024
13 checks passed
@npaun npaun deleted the npaun/zlib-sync-tests branch August 29, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants