Log when deleteAll is called with an alarm still set on the object #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-robinson
force-pushed
the
arobinson/log-deleteall-alarm
branch
from
d836421
to
9843552
Compare
jclee
approved these changes
Aug 29, 2024
justin-mp
approved these changes
Aug 30, 2024
|
Should this use LOG_PERIODICALLY in case this is very common? |
a-robinson
force-pushed
the
arobinson/log-deleteall-alarm
branch
2 times, most recently
from
5a83db6
to
597d20b
Compare
I was hoping to avoid that so that we could get more complete data, operating under the assumption that deleteAll itself is only used very infrequently, and that it should be even less frequent in combination with alarms. But now I feel obligated to since it'll look silly if that assumption ends up being wrong 🙃 Switched it over. |
a-robinson
force-pushed
the
arobinson/log-deleteall-alarm
branch
from
597d20b
to
e85eee8
Compare
To get a better sense of the prevalence of this usage pattern.
a-robinson
force-pushed
the
arobinson/log-deleteall-alarm
branch
from
e85eee8
to
5ffbf6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a better sense of the prevalence of this usage pattern.