Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three more node:zlib tests #2635

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Three more node:zlib tests #2635

merged 3 commits into from
Aug 30, 2024

Conversation

npaun
Copy link
Member

@npaun npaun commented Aug 30, 2024 •
edited
Loading

Nice small PR for EOD Friday. Adds two tests from NodeJS. Actually, we'll throw in a third one at no additional cost.

  • test-zlib-flush.js (currently fails)
  • test-zlib-dictionary.js (all good!)
  • test-zlib-close-after-write (all good!)

@npaun npaun requested review from jasnell and anonrig August 30, 2024 20:49
@npaun npaun requested review from a team as code owners August 30, 2024 20:49
@npaun npaun changed the title Two more node:zlib tests Three more node:zlib tests Aug 30, 2024
@npaun npaun merged commit 295128b into main Aug 30, 2024
13 checks passed
@npaun npaun deleted the npaun/zlib-tests-2 branch August 30, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npaun @jasnell