Implement brotli one shot methods #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npaun
force-pushed
the
npaun/brotli-one-shot
branch
5 times, most recently
from
e797392
to
3f23a80
Compare
jasnell
reviewed
Sep 5, 2024
npaun
force-pushed
the
npaun/brotli-one-shot
branch
from
d6f1008
to
d09f138
Compare
jasnell
reviewed
Sep 5, 2024
jasnell
reviewed
Sep 5, 2024
npaun
force-pushed
the
npaun/brotli-one-shot
branch
from
d09f138
to
2b432c2
Compare
anonrig
reviewed
Sep 5, 2024
| queueMicrotask(() => { | ||
| if (error) { | ||
| callback(new Error(error)); | ||
| if (res instanceof Error) { |
There was a problem hiding this comment.
Nit: Is there a way to avoid this check on the runtime. Checking for truthy value vs. instanceof checks have different characteristics and runtime performance costs.
There was a problem hiding this comment.
I'll look into whether some template voodoo is possible
Add more brotli tests
npaun
force-pushed
the
npaun/brotli-one-shot
branch
from
2b432c2
to
05f6554
Compare
anonrig
approved these changes
Sep 9, 2024
jasnell
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.