Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Workflow binding module #2677

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

sidharthachatterjee
Copy link
Collaborator

@sidharthachatterjee sidharthachatterjee commented Sep 9, 2024

Adds a wrapped binding for Workflow, primarily works by calling a fetcher attached to the pipeline

@sidharthachatterjee sidharthachatterjee marked this pull request as ready for review September 9, 2024 20:38
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be some tests?

src/cloudflare/internal/workflows-api.ts Outdated Show resolved Hide resolved
src/cloudflare/internal/workflows-api.ts Outdated Show resolved Hide resolved
src/cloudflare/internal/workflows-api.ts Outdated Show resolved Hide resolved
@sidharthachatterjee sidharthachatterjee force-pushed the sidharthachatterjee/workflow-binding branch 3 times, most recently from 3a9f750 to 887a674 Compare September 11, 2024 20:20
@sidharthachatterjee sidharthachatterjee force-pushed the sidharthachatterjee/workflow-binding branch 6 times, most recently from 66837d3 to 5337d12 Compare September 11, 2024 21:02
@sidharthachatterjee sidharthachatterjee merged commit e2d40ae into main Sep 11, 2024
12 of 13 checks passed
@sidharthachatterjee sidharthachatterjee deleted the sidharthachatterjee/workflow-binding branch September 11, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants