More incremental impl of new module registry #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/continue-new-module-registry-incremental
branch
from
6f19ba3
to
ba6f6f5
Compare
|
hmm... not sure why the linux-debug test is failing here. |
anonrig
reviewed
Sep 9, 2024
jasnell
force-pushed
the
jsnell/continue-new-module-registry-incremental
branch
from
ba6f6f5
to
07c9262
Compare
jasnell
commented
Sep 10, 2024
jasnell
force-pushed
the
jsnell/continue-new-module-registry-incremental
branch
2 times, most recently
from
c234ec6
to
9f774c4
Compare
anonrig
approved these changes
Sep 10, 2024
jasnell
force-pushed
the
jsnell/continue-new-module-registry-incremental
branch
from
9f774c4
to
31498f6
Compare
Starts adding api tests, fixing up some behaviors.
jasnell
force-pushed
the
jsnell/continue-new-module-registry-incremental
branch
from
31498f6
to
b196d74
Compare
anonrig
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More incremental work on new module registry... bit-by-bit slowly getting done....
Starts adding api tests, fixing up some behaviors.