speed up url.c++ scheme and port detection #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/speed-up-url
branch
from
bd63074
to
cf73291
Compare
jasnell
approved these changes
Sep 10, 2024
npaun
reviewed
Sep 10, 2024
npaun
reviewed
Sep 10, 2024
npaun
approved these changes
Sep 10, 2024
jasnell
reviewed
Sep 10, 2024
jasnell
reviewed
Sep 10, 2024
jasnell
approved these changes
Sep 10, 2024
Co-authored-by: Nicholas Paun <[email protected]>
Co-authored-by: Nicholas Paun <[email protected]>
anonrig
force-pushed
the
yagiz/speed-up-url
branch
from
c006f87
to
25fecf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing Ada, we found out that checking if URL is special or not, and getting the default port of a scheme had extremely high cost. Let's apply the same optimizations we did on Ada, on workerd.