Un-ship SQL prepared statements. #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intend to make `exec()` automatically memoize prepared statements such that no application should ever be preparing statements manually. So, let's not even ship the API. It's not yet possible to enable the SQL API in prod without the experimental flag so it's still safe to put `prepare()` back behind that flag.
lambrospetrou
approved these changes
Sep 17, 2024
a-robinson
approved these changes
Sep 17, 2024
justin-mp
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to make
exec()automatically memoize prepared statements such that no application should ever be preparing statements manually. So, let's not even ship the API.It's not yet possible to enable the SQL API in prod without the experimental flag so it's still safe to put
prepare()back behind that flag.