Enable clang-format AllowShortBlocksOnASingleLine #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npaun
approved these changes
Sep 18, 2024
jasnell
approved these changes
Sep 18, 2024
This looks much cleaner and readable IMHO. There is also an "Always" option for this, but its output feels less readable to me.
fhanau
force-pushed
the
felix/compact-short-blocks
branch
from
c28dda1
to
9ad67cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks much cleaner and readable IMHO. There is also an "Always" option for this, but its output feels less readable to me.
=============
See https://clang.llvm.org/docs/ClangFormatStyleOptions.html#allowshortblocksonasingleline. I don't remember how I found this but it might have been improved/fixed in LLVM 18/19.