enable v8_enable_local_off_stack_check compile time flag #2752
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 19, 2024
anonrig
force-pushed
the
yagiz/workerd-patches
branch
3 times, most recently
from
6dc21a5
to
32b2cef
Compare
anonrig
force-pushed
the
yagiz/workerd-patches
branch
from
32b2cef
to
ca9840a
Compare
fhanau
reviewed
Sep 19, 2024
.bazelrc
Outdated
| @@ -61,6 +61,9 @@ build --host_per_file_copt='external/zlib@-Wno-unknown-warning-option,-Wnodeprec | |||
| build --per_file_copt=external/com_google_tcmalloc@-DANNOTATE_MEMORY_IS_INITIALIZED=ABSL_ANNOTATE_MEMORY_IS_INITIALIZED | |||
| build --per_file_copt=external/com_google_protobuf@-Wno-deprecated-declarations,-Wno-deprecated-pragma | |||
| build --host_per_file_copt=external/com_google_protobuf@-Wno-deprecated-declarations,-Wno-deprecated-pragma | |||
| # Enables heap allocation debug checks for local handles. | |||
| # Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4905902 | |||
| build --per_file_copt='external/v8@-DV8_ENABLE_LOCAL_OFF_STACK_CHECK' | |||
There was a problem hiding this comment.
Actually I was wrong about this only being needed when building V8: Since the define present in include/v8-local-handle.h and include/v8-fast-api-calls.h we also need to apply it when building our own code. Let's change this to a regular copt.
|
Nit: We reproduce V8 build flags in |
anonrig
force-pushed
the
yagiz/workerd-patches
branch
from
ca9840a
to
6b128a6
Compare
|
I've submitted a patch to v8 to fix this error. https://chromium-review.googlesource.com/c/v8/v8/+/5876953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing the original commit introducing the flag:
Local handles (object of the v8::Local) should never be allocated on the heap, and we should use
v8::LocalVectorinstead of heap allocation. This flag ensures that we follow v8 recommendation.