Revert the revert of fastEncodeBase64Url method
#2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d0f8e89.
jasnell
approved these changes
Sep 24, 2024
anonrig
force-pushed
the
yagiz/revert-revert-encode-base64
branch
from
3c4bf19
to
92e93b1
Compare
|
Internal PR passes |
jclee
reviewed
Sep 24, 2024
| auto output = kj::heapArray<char>(expected_length + 1); | ||
| auto actual_length = simdutf::binary_to_base64( | ||
| bytes.asChars().begin(), bytes.size(), output.asChars().begin(), simdutf::base64_url); | ||
| output[actual_length] = '\0'; |
There was a problem hiding this comment.
FWIW, I noticed the old code had an assert that expected was close to actual. But maybe this isn't crucial to recheck, if we trust simdutf to make the same guarantee with regard to base64_length_from_binary() and binary_to_base64().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the suggestion of adding a null terminator before passing the input to
kj::StringReverts #2776