disabling all precommit hooks that depend on external binaries #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This got out of hand and many developers report problems. All third-party dependencies need to be fetched by bazel if they are a requirement for workerd development.
mar-cf
approved these changes
Sep 24, 2024
anonrig
approved these changes
Sep 24, 2024
|
I think we can just disable the git hooks as well. |
let them be? I'd like to see these linters reborn. |
jasnell
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got out of hand and many developers report problems. All third-party dependencies need to be fetched by bazel if they are a requirement for workerd development.
Feel free to uncomment particular formatters once dependency management is fixed.
This is not a reflection on linters/formatters at all: they are super useful and we should continue increasing the coverage.