[nfc] ruff: disable too many branches/statements #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imo these are arbitrary and are often fought with.
|
Pretty meh on this one. I dislike long and complex functions, but those limits seem low. |
This is what code-reviewers are for. As it is I can't land simple script just because it has 52 statements and not 50. Don't know who benefits from this one. |
anonrig
approved these changes
Sep 24, 2024
|
Thanks @mikea! |
jclee
pushed a commit
that referenced
this pull request
Oct 11, 2024
Imo these are arbitrary and are often fought with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imo these are arbitrary and are often fought with.