Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset WebSocket outgoing message status in a single continuation #379

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Reset WebSocket outgoing message status in a single continuation #379

merged 2 commits into from
Feb 21, 2023

Conversation

bcaimano
Copy link
Contributor

No description provided.

kentonv
kentonv approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@kentonv kentonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of coroutines cleaned up the output lock handling nicely!

src/workerd/api/web-socket.c++ Show resolved Hide resolved
src/workerd/api/web-socket.c++ Show resolved Hide resolved
@xortive xortive marked this pull request as ready for review February 15, 2023 21:15
@xortive xortive force-pushed the bcaimano/web-socket-pump branch 2 times, most recently from 2403a5e to 56c716b Compare February 16, 2023 18:24
@xortive xortive merged commit c336d40 into main Feb 21, 2023
@kentonv kentonv deleted the bcaimano/web-socket-pump branch February 24, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@kentonv kentonv kentonv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcaimano @jasnell @kentonv @xortive