Add initial minimal set of node:assert tests #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/add-nodejs-assert-tests
branch
from
551f652
to
68bc781
Compare
jasnell
force-pushed
the
jsnell/add-nodejs-assert-tests
branch
from
68bc781
to
296e0ef
Compare
mikea
approved these changes
Feb 28, 2023
| @@ -0,0 +1,138 @@ | |||
| import { | |||
There was a problem hiding this comment.
I wonder if there's any value in writing these in TS?
There was a problem hiding this comment.
maybe? I think there's a more general question there about whether workerd should handle typescript transparently if tsc is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.