Move RequestTracker into workerd and use it in Worker::Actor #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaimano
reviewed
Mar 6, 2023
| private: | ||
| kj::Own<const Worker> worker; | ||
|
|
||
| // TODO(soon): Provide a RequestTracker in workerd so this can no longer be a Maybe |
There was a problem hiding this comment.
Hmmmm, what do you have in mind? It would be nice if we could just take care of it in this PR.
There was a problem hiding this comment.
it's a large enough piece of work I prefer to land it separately
bcaimano
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Thanks for your work moving this over!
Mind tagging @MellowYarker as a co-author? He did a decent part of the work internally (https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors).
xortive
force-pushed
the
malonso/refactor-actor-deferred-proxying
branch
3 times, most recently
from
c602cc1
to
aa63aef
Compare
…making kj::Own<Worker::Actor> instances with an ActiveRequest attached Co-authored-by: Milan Miladinovic <[email protected]>
xortive
force-pushed
the
malonso/refactor-actor-deferred-proxying
branch
from
aa63aef
to
8b908f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.