Do not sanitize internal error messages in jsg::annotateBroken() #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaimano
requested review from
jclee,
jasnell,
xortive,
jqmmes and
MellowYarker
bcaimano
force-pushed
the
bcaimano/fix-annotate-brokenness
branch
from
dcbe31c
to
5f28bd9
Compare
jasnell
approved these changes
Apr 15, 2023
This commit does the following: - Preserves the original message for internal exceptions that pass through jsg::annotateBroken(). It turns out that we only expect to see non-JSG messages in situations where `Worker::Actor::Impl::makeStorage()` throws. Up until recently, all storage interfaces had trivial construction, so it was never an issue. Since this is difficult to do in a testing environment, I have verified the messages manually. - Reorganizes cases when making a `DecodedException` so that kj exceptions get their own branch with a default exception. - Sanitizes jsg-internal exceptions when extracting descriptions for use with the worker logging. - Logs at info level when we annotate an exception with brokenness.
bcaimano
force-pushed
the
bcaimano/fix-annotate-brokenness
branch
from
5f28bd9
to
b57bedb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does the following:
Worker::Actor::Impl::makeStorage()throws. Up until recently, all storage interfaces had trivial construction, so it was never an issue. Since this is difficult to do in a testing environment, I have verified the messages manually.DecodedExceptionso that kj exceptions get their own branch with a default exception.