Implement crypto.pbkdf2 #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
May 5, 2023
jasnell
reviewed
May 5, 2023
fhanau
force-pushed
the
felix/node-crypto-hkdf2
branch
3 times, most recently
from
120be04
to
e8b39ad
Compare
fhanau
force-pushed
the
felix/node-crypto-hkdf2
branch
from
e8b39ad
to
e1cc3c4
Compare
jasnell
reviewed
May 9, 2023
| JSG_REQUIRE(password.size() < INT32_MAX, RangeError, | ||
| "Pbkdf2 failed: password is too large"); | ||
| JSG_REQUIRE(salt.size() < INT32_MAX, RangeError, | ||
| "Pbkdf2 failed: password is too large"); |
There was a problem hiding this comment.
Suggested change
| "Pbkdf2 failed: password is too large"); | |
| "Pbkdf2 failed: salt is too large"); |
jasnell
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the
crypto.pbkdf2Sync()andcrypto.pbkdf2()functions. Work is still needed in a few places, notably async has not been implemented. For some of these changes, it is probably better when some of the other crypto PRs get merged first, e.g. to establishnode-internal:crypto_util.