Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes assert due to Flush in WritableStreamInternalController. #672

Merged
merged 1 commit into from
May 19, 2023
Merged

Fixes assert due to Flush in WritableStreamInternalController. #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/workerd/api/streams/internal.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,8 +1237,8 @@ jsg::Promise<void> WritableStreamInternalController::writeLoopAfterFrontOutputLo
using Request = kj::Decay<decltype(request)>;

return [this, &request]() -> decltype(auto) {
if constexpr (kj::isSameType<Request, Write>()) {
// Write requests can have any number of requests backed up after them.
if constexpr (kj::isSameType<Request, Write>() || kj::isSameType<Request, Flush>()) {
// Write and flush requests can have any number of requests backed up after them.
KJ_ASSERT(!queue.empty());
} else {
// Pipe and Close requests are always the last one in the queue.
Expand Down