Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v8 11.4.183.12 #678

Closed
wants to merge 5 commits into from
Closed

Update to v8 11.4.183.12 #678

wants to merge 5 commits into from

Conversation

ohodson
Copy link
Contributor

@ohodson ohodson commented May 21, 2023

Test: bazel test //...

@ohodson ohodson requested a review from kentonv May 21, 2023 19:19
@ohodson ohodson changed the title Update to v8 11.4.183.8 Update to v8 11.4.183.12 May 22, 2023
Copy link
Collaborator

@harrishancock harrishancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new v8-updates.md document -- thanks for writing it!

Non-blocking nit, but could you add guidance on how to update shallow_since, too? Do you just take the output of date -u +"%s %z"?

Test: bazel test //...
Adds `bazel clean` and `bazel clean --expunge` tasks to tasks.json.

Fixes a typo for the fastbuild compilation mode task.
@ohodson
Copy link
Contributor Author

ohodson commented May 23, 2023

I've added a note in 82d3611. There is probably some git magic to establish that date, but bazel spits it out during the build.

ohodson added a commit that referenced this pull request May 24, 2023
Incorporates review comments in
#678

* Patches should be generated with --full-index
* Adds a note about shallow-since

Bug: EW-7428
Test: bazel build //...
ohodson added a commit that referenced this pull request May 24, 2023
Incorporates review comments in
#678
relating to v8-updates.md:

* Patches should be generated with --full-index
* Adds a note about shallow-since

Also includes some re-wording of v8-updates.md and
regenerates V8 patches with --full-index.

Bug: EW-7428
Test: bazel build //...
ohodson added a commit that referenced this pull request May 24, 2023
Incorporates review comments in
#678
relating to v8-updates.md:

* Patches should be generated with --full-index
* Adds a note about shallow-since

Also includes some re-wording of v8-updates.md and
regenerates V8 patches with --full-index.

Bug: EW-7428
Test: bazel build //...
@ohodson
Copy link
Contributor Author

ohodson commented May 25, 2023

Folded into #689

Review comment suggestions that missed the folding are in #697

@ohodson ohodson closed this May 25, 2023
ohodson added a commit that referenced this pull request May 26, 2023
Incorporates review comments in
#678
relating to v8-updates.md:

* Patches should be generated with --full-index
* Adds a note about shallow-since

Also includes some re-wording of v8-updates.md and
regenerates V8 patches with --full-index.

Bug: EW-7428
Test: bazel build //...
@fhanau fhanau deleted the orion/v8-11.4 branch September 25, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants