-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v8 11.4.183.12 #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice new v8-updates.md document -- thanks for writing it!
Non-blocking nit, but could you add guidance on how to update shallow_since
, too? Do you just take the output of date -u +"%s %z"
?
Test: bazel test //...
Adds `bazel clean` and `bazel clean --expunge` tasks to tasks.json. Fixes a typo for the fastbuild compilation mode task.
I've added a note in 82d3611. There is probably some git magic to establish that date, but bazel spits it out during the build. |
Incorporates review comments in #678 * Patches should be generated with --full-index * Adds a note about shallow-since Bug: EW-7428 Test: bazel build //...
Incorporates review comments in #678 relating to v8-updates.md: * Patches should be generated with --full-index * Adds a note about shallow-since Also includes some re-wording of v8-updates.md and regenerates V8 patches with --full-index. Bug: EW-7428 Test: bazel build //...
Incorporates review comments in #678 relating to v8-updates.md: * Patches should be generated with --full-index * Adds a note about shallow-since Also includes some re-wording of v8-updates.md and regenerates V8 patches with --full-index. Bug: EW-7428 Test: bazel build //...
Incorporates review comments in #678 relating to v8-updates.md: * Patches should be generated with --full-index * Adds a note about shallow-since Also includes some re-wording of v8-updates.md and regenerates V8 patches with --full-index. Bug: EW-7428 Test: bazel build //...
Test: bazel test //...