Handle synchronous JS exceptions in PumpToReader #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
May 24, 2023
kentonv
reviewed
May 24, 2023
kentonv
reviewed
May 24, 2023
kentonv
reviewed
May 24, 2023
kentonv
reviewed
May 24, 2023
jasnell
force-pushed
the
jsnell/streams-then-uncaught-jsexceptionthrown
branch
3 times, most recently
from
1d2ff71
to
1ffe2a5
Compare
kentonv
reviewed
May 24, 2023
jasnell
force-pushed
the
jsnell/streams-then-uncaught-jsexceptionthrown
branch
2 times, most recently
from
70d4499
to
a0f1e1e
Compare
kentonv
reviewed
May 24, 2023
kentonv
reviewed
May 24, 2023
kentonv
approved these changes
May 24, 2023
jasnell
force-pushed
the
jsnell/streams-then-uncaught-jsexceptionthrown
branch
from
ee386df
to
de23514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.