Workerd V8 update to 11.5 #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohodson
force-pushed
the
orion/v8-11.5-update
branch
from
66b460a
to
192677f
Compare
Drops patch for mksnapshot that has been fixed since 11.4. Adds platform-win32.h to the declared dependencies of @v8//:v8_libbase in 0007-Allow-Windows-builds-under-Bazel.patch. Test: bazel test //...
Test: bazel build //...
ohodson
force-pushed
the
orion/v8-11.5-update
branch
from
192677f
to
9a6ac0d
Compare
Allow tests to run in different compilation modes.
ohodson
force-pushed
the
orion/v8-11.5-update
branch
from
702236c
to
4061b87
Compare
|
I've grouped these together as they come up in the course of trying V8 11.5 on OS X / Windows, but the later two commits are strictly orthogonal. |
jasnell
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.