workerd: Use --single-threaded-gc #803
Conversation
Consecutive requests could lead to calling into the isolate whilst code pages are being collected. This problem has only been observed on macOS arm64. Bug: CUSTESC-29094 Bug: cloudflare/workers-sdk#2386 Review: #803
ohodson
force-pushed
the
orion/dont-gc-live-code
branch
from
e3b85c9
to
1e80d05
Compare
|
Is this a bug in V8? Or is our code doing something wrong / unusual that causes this? Can we #ifdef the fix to mac, if it's only seen on mac? |
Consecutive requests could lead to calling into the isolate whilst code pages are being collected. This problem has only been observed on macOS arm64. Bug: CUSTESC-29094 Bug: cloudflare/workers-sdk#2386 Review: #803
This reverts commit d0ac3f3. The preceding commit adding --single-threaded-gc addresses the issue. Bug: CUSTESC-29094 Bug: cloudflare/workers-sdk#2386
ohodson
force-pushed
the
orion/dont-gc-live-code
branch
from
155fc68
to
f5f7c40
Compare
In our use case, a GC has been triggered by a request and happens to be still running when the next request is handled. Normally, you'd expect synchronization logic to prevent executable pages losing the X bit whilst the code is still reachable. macOS has some different page permission constraints and I don't yet know if the problem is a failure in synchronization, an assumption that doesn't apply in the workerd use case, or if there is something that is missing in
Done. |
Consecutive requests could lead to calling into the isolate whilst code pages are being collected. This problem has only been observed on macOS arm64. Bug: CUSTESC-29094 Bug: cloudflare/workers-sdk#2386 Review: #803
workerd: Use --single-threaded-gc
Consecutive requests could lead to calling into the isolate whilst code pages are being collected. This problem has only been observed on macOS arm64.
Bug: CUSTESC-29094
Bug: cloudflare/workers-sdk#2386