Mark Node.js createPrivateKey/createPublicKey unimplemented for now #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
changed the title
fhanau
approved these changes
Jun 27, 2023
jasnell
force-pushed
the
jsnell/nodejs-compat-crypto-no-key-generation
branch
from
b7dcfcc
to
a1542bf
Compare
jasnell
force-pushed
the
jsnell/nodejs-compat-keyobject-createprivatekey-createpublickey
branch
from
c51a81c
to
723f41a
Compare
jasnell
force-pushed
the
jsnell/nodejs-compat-crypto-no-key-generation
branch
from
a1542bf
to
e7e8f3f
Compare
jasnell
force-pushed
the
jsnell/nodejs-compat-keyobject-createprivatekey-createpublickey
branch
from
723f41a
to
21c23df
Compare
Base automatically changed from
jsnell/nodejs-compat-crypto-no-key-generation
to
main
June 29, 2023 00:18
Implementing these cleanly will require a larger refactoring of the current key import logic supporting Web Crypto as the currently design makes a lot of assumptions that Web Crypto semantics are being used. For now we'll just mark these as unimplemented and revisit in a later iteration.
jasnell
force-pushed
the
jsnell/nodejs-compat-keyobject-createprivatekey-createpublickey
branch
from
21c23df
to
f34878b
Compare
kentonv
deleted the
jsnell/nodejs-compat-keyobject-createprivatekey-createpublickey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node.js compat crypto createPrivateKey and createPublicKey APIs are the rough equivalent to Web Crypto importKey for key pairs. Unfortunately they provide a range of options that are not currently supported by the Web Crypto implementation. The current Web Crypto implementation either needs to be refactored or duplicated in a number of ways in order to properly support createPrivateKey/createPublicKey. For now, we'll mark these apis as unimplemented and will revisit once the import key internals have been sufficiently refactored.