Implement MimeType parser and class #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/nodejs-compat-util-mimetype
branch
from
d650c22
to
6d81d2f
Compare
ohodson
reviewed
Jul 5, 2023
ohodson
reviewed
Jul 5, 2023
ohodson
reviewed
Jul 5, 2023
ohodson
reviewed
Jul 5, 2023
ohodson
reviewed
Jul 5, 2023
|
LGTM modulo test failure resolution. |
jasnell
force-pushed
the
jsnell/nodejs-compat-util-mimetype
branch
3 times, most recently
from
2e64c72
to
c3cef34
Compare
jasnell
force-pushed
the
jsnell/nodejs-compat-util-mimetype
branch
from
c3cef34
to
a42e996
Compare
ohodson
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Node.js MIMEType API. Implemented in C++ because this also addresses a number of internal TODOs by implementing a proper MIME type parser internally.