New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap order of r2 put types to fix type on onlyif #908

Merged

jasnell merged 1 commit into cloudflare:main from Frederik-Baetens:fbaetens/fix_r2_put_type

Aug 9, 2023

Contributor

Frederik-Baetens commented Jul 24, 2023

No description provided.

Frederik-Baetens force-pushed the fbaetens/fix_r2_put_type branch from 2ef9743 to 5b09d5b Compare

July 24, 2023 19:28

jasnell approved these changes

View reviewed changes

Frederik-Baetens force-pushed the fbaetens/fix_r2_put_type branch 2 times, most recently from dd6b152 to 84c8b05 Compare

July 24, 2023 22:53

Contributor Author

Frederik-Baetens commented Jul 29, 2023

@jasnell do you know why the windows CI is failing? I've ran it twice and it's still failing.


          change order of r2 put types

Frederik-Baetens force-pushed the fbaetens/fix_r2_put_type branch from 84c8b05 to 5431419 Compare

August 9, 2023 21:57

jasnell merged commit 37d4b8c into cloudflare:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet