Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Fetcher#scheduled() for dispatching scheduled events #961

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Aug 2, 2023

Hey! 👋 This PR implements a Fetcher#scheduled() method for dispatching scheduled events to bound services. This will allow us to add support for triggering scheduled events in Miniflare without transforming user code. Like Fetcher#queue(), this is gated behind the experimental service_binding_extra_handlers compatibility flag.

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's also get @kentonv's opinion

Like `Fetcher#queue()`, this is gated behind the experimental
`service_binding_extra_handlers` compatibility flag.

Co-authored-by: jjohnson <[email protected]>
Copy link
Member

@kentonv kentonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me as long as it stays guarded by that compat flag. We'd need to do some thinking before making this more generally available.

@mrbbot mrbbot merged commit f0ea846 into main Aug 3, 2023
7 checks passed
@mrbbot mrbbot deleted the jspspike/scheduled-event branch August 3, 2023 07:28
mrbbot added a commit to cloudflare/miniflare that referenced this pull request Aug 8, 2023
mrbbot added a commit to cloudflare/workers-sdk that referenced this pull request Oct 31, 2023
mrbbot added a commit to cloudflare/workers-sdk that referenced this pull request Nov 1, 2023
mrbbot added a commit to cloudflare/workers-sdk that referenced this pull request Nov 1, 2023
mrbbot added a commit to cloudflare/workers-sdk that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants