This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 151
Alewis/custom webpack config for sites #606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleymichal
force-pushed
the
alewis/custom-webpack-config-for-sites
branch
from
December 17, 2019 22:42
998110b
to
180d961
Compare
exvuma
suggested changes
Jan 3, 2020
A suggestion to give a broader example on this. and it is a suggestion, but wanted to put it here since is something I found out as I was testing: you can have now the following folder structure:
This allowed us to have on the files:
and the index.js can easily import from the This is great for monolith repos for multiple workers and paths. |
xtuc
reviewed
Feb 11, 2020
exvuma
reviewed
May 6, 2020
ashleymichal
commented
May 6, 2020
ashleymichal
force-pushed
the
alewis/custom-webpack-config-for-sites
branch
from
May 6, 2020 21:40
80f52c4
to
f6dfb36
Compare
exvuma
reviewed
May 6, 2020
exvuma
approved these changes
May 8, 2020
ashleymichal
force-pushed
the
alewis/custom-webpack-config-for-sites
branch
from
May 8, 2020 15:08
be2da77
to
ed2feb3
Compare
delete-merged-branch
bot
deleted the
alewis/custom-webpack-config-for-sites
branch
May 8, 2020 15:27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #602
please advise on verbiage. it felt easier to explain
context
thanentry
, but i could be convinced otherwise.