Skip to content

Commit

Permalink
Update .changeset/gentle-ladybugs-tap.md
Browse files Browse the repository at this point in the history
Co-authored-by: Jacob M-G Evans <[email protected]>
  • Loading branch information
threepointone and JacobMGEvans authored Jun 14, 2022
1 parent 282eebd commit b75e8cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .changeset/gentle-ladybugs-tap.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@

fix: resolve asset handler for `--experimental-path`

In https://github.com/cloudflare/wrangler2/pull/1241, we removed the vendored version of `@cloudflare/kv-asset-handler`, as well as the build configuration that would point to the vendored version when compining a worker using `--experimental-public`. However, wrangler can be used where it's not installed in the `package.json` for the worker, or even when there's no package.json at all (like when wrangler is installed globally, or used with `npx`). In this situation, if the user doesn't have `@cloudflare/kv-asset-handler` installed, then building the worker will fail. We don't want to make the user install this themselves, so instead we point to a barrel import for the library in the facade for the worker.
In https://github.com/cloudflare/wrangler2/pull/1241, we removed the vendored version of `@cloudflare/kv-asset-handler`, as well as the build configuration that would point to the vendored version when compiling a worker using `--experimental-public`. However, wrangler can be used where it's not installed in the `package.json` for the worker, or even when there's no package.json at all (like when wrangler is installed globally, or used with `npx`). In this situation, if the user doesn't have `@cloudflare/kv-asset-handler` installed, then building the worker will fail. We don't want to make the user install this themselves, so instead we point to a barrel import for the library in the facade for the worker.

0 comments on commit b75e8cf

Please sign in to comment.