Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve asset handler for --experimental-path #1253

Merged
merged 2 commits into from
Jun 14, 2022
Merged

fix: resolve asset handler for --experimental-path #1253

merged 2 commits into from
Jun 14, 2022

Commits on Jun 14, 2022

  1. fix: resolve asset handler for --experimental-path 

    In #1241, we removed the vendored version of `@cloudflare/kv-asset-handler`, as well as the build configuration that would point to the vendored version when compining a worker using `--experimental-public`. However, wrangler can be used where it's not installed in the `package.json` for the worker, or even when there's no package.json at all (like when wrangler is installed globally, or used with `npx`). In this situation, if the user doesn't have `@cloudflare/kv-asset-handler` installed, then building the worker will fail. We don't want to make the user install this themselves, so instead we point to a barrel import for the library in the facade for the worker.
    @threepointone
    threepointone committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    282eebd View commit details
    Browse the repository at this point in the history

  2. Update .changeset/gentle-ladybugs-tap.md 

    Co-authored-by: Jacob M-G Evans <[email protected]>
    @threepointone @JacobMGEvans
    threepointone and JacobMGEvans authored Jun 14, 2022
    Configuration menu
    Copy the full SHA
    b75e8cf View commit details
    Browse the repository at this point in the history