Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esbuild to 0.15.18 #2422

Closed
wants to merge 7 commits into from
Closed

Update esbuild to 0.15.18 #2422

wants to merge 7 commits into from

Conversation

Edweis
Copy link

@Edweis Edweis commented Dec 16, 2022

What this PR solves / how to test:

The current esbuild version used in wrangler is 0.14.51 and does not support the satisfies operator.
This is now supported since esbuild 0.15.14.

This PR updated esbuild version to the latest, 0.15.18.

Associated docs issues/PR:

Author has included the following, where applicable:

  • Tests
  • Changeset

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Fixes #1971 .

@Edweis Edweis requested a review from a team as a code owner December 16, 2022 09:19
@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022

🦋 Changeset detected

Latest commit: 292c434

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
wranglerjs-compat-webpack-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Edweis Edweis changed the title update Update esbuild to 0.15.15 Dec 16, 2022
@Edweis Edweis changed the title Update esbuild to 0.15.15 Update esbuild to 0.15.18 Dec 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/3801655925/npm-package-wrangler-2422

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2422/npm-package-wrangler-2422

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/runs/3801655925/npm-package-wrangler-2422 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/runs/3801655925/npm-package-cloudflare-pages-shared-2422

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2422 (761bb43) into main (15cfd01) will decrease coverage by 0.28%.
The diff coverage is n/a.

❗ Current head 761bb43 differs from pull request most recent head 292c434. Consider uploading reports for the commit 292c434 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2422      +/-   ##
==========================================
- Coverage   71.43%   71.14%   -0.29%     
==========================================
  Files         155      155              
  Lines        9690     9771      +81     
  Branches     2535     2555      +20     
==========================================
+ Hits         6922     6952      +30     
- Misses       2768     2819      +51     
Impacted Files Coverage Δ
packages/wrangler/src/deployments.ts 71.42% <0.00%> (-15.53%) ⬇️
packages/wrangler/src/tail/printing.ts 78.18% <0.00%> (-7.54%) ⬇️
packages/wrangler/src/generate/index.ts 71.62% <0.00%> (-4.10%) ⬇️
.../wrangler/src/__tests__/helpers/mock-web-socket.ts 88.88% <0.00%> (-3.97%) ⬇️
packages/wrangler/src/create-worker-upload-form.ts 90.19% <0.00%> (-2.52%) ⬇️
packages/wrangler/src/tail/index.ts 90.54% <0.00%> (-2.42%) ⬇️
packages/wrangler/src/tail/filters.ts 96.07% <0.00%> (-1.80%) ⬇️
packages/wrangler/src/pages/deployment-tails.tsx 82.10% <0.00%> (-1.60%) ⬇️
packages/wrangler/src/init.ts 93.55% <0.00%> (-1.02%) ⬇️
packages/wrangler/src/routes.ts 27.41% <0.00%> (-0.92%) ⬇️
... and 9 more

@rozenmd
Copy link
Contributor

rozenmd commented Dec 29, 2022

There's something weird happening with @esbuild-plugins/node-globals-polyfill and @esbuild-plugins/node-modules-polyfill that breaks node-compat in our tests 😕

@rozenmd
Copy link
Contributor

rozenmd commented Feb 1, 2023

Closing this in favour of #2661

@rozenmd rozenmd closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants