Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] Pass through nodejs_compat to pages functions build #3100

Closed
wants to merge 1 commit into from

Conversation

penalosa
Copy link
Contributor

Fixes cloudflare/next-on-pages#199

What this PR solves / how to test:

  • Fixes passing the nodejs_compat flag through to wrangler pages functions build

cc @dario-piotrowicz

Reviewer has performed the following, where applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@penalosa penalosa requested a review from a team as a code owner April 27, 2023 17:59
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: b5c3c89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa changed the title Pass through nodejs compat to pages functions build [wrangler] Pass through nodejs_compat to pages functions build Apr 27, 2023
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4822927220/npm-package-wrangler-3100

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3100/npm-package-wrangler-3100

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4822927220/npm-package-wrangler-3100 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4822927220/npm-package-cloudflare-pages-shared-3100

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #3100 (b5c3c89) into main (a487116) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3100      +/-   ##
==========================================
+ Coverage   74.27%   74.30%   +0.02%     
==========================================
  Files         168      168              
  Lines       10530    10530              
  Branches     2815     2815              
==========================================
+ Hits         7821     7824       +3     
+ Misses       2709     2706       -3     
Impacted Files Coverage Δ
packages/wrangler/src/pages/build.ts 67.03% <ø> (ø)

... and 2 files with indirect coverage changes

@GregBrimble
Copy link
Member

Would be cool to add a test for this, but no biggie. Ty for the fix.

@dario-piotrowicz
Copy link
Member

quick reminder for @penalosa that we still need to update the nodejs_compat error message here 🙂

@penalosa penalosa closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Nextjs v13.3.1 fresh install worker threw exception
3 participants